Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetDurationUnitOptions: Unit strings not properly formatted in step 6.c #154

Closed
anba opened this issue Jun 9, 2023 · 0 comments · Fixed by #166
Closed

GetDurationUnitOptions: Unit strings not properly formatted in step 6.c #154

anba opened this issue Jun 9, 2023 · 0 comments · Fixed by #166

Comments

@anba
Copy link
Contributor

anba commented Jun 9, 2023

proposal-intl-duration-format/spec.emu

Lines 229 to 230 in 4c7efed

1. If _style_ is *"numeric"* and _display_ is *"always"* and _unit_ is one of "milliseconds", "microseconds", or "nanoseconds", then
1. Throw a *RangeError* exception.

The unit strings should be formatted as string literals using *.
anba added a commit to anba/proposal-intl-duration-format that referenced this issue Aug 22, 2023
@anba
Editorial: Fix markup for string values
257af48 
Fixes tc39#154
anba added a commit to anba/proposal-intl-duration-format that referenced this issue Aug 22, 2023
@anba
Editorial: Fix markup for string values
c94aeb5 
Fixes tc39#154
@anba anba mentioned this issue Aug 22, 2023
Merged
ben-allen pushed a commit that referenced this issue Oct 16, 2023
@anba @ben-allen
Editorial: Fix markup for string values
827fb4b 
Fixes #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Various editorial updates anba/proposal-intl-duration-format
1 participant
@anba