Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Unnecessary exception check for IsStructurallyValidLanguageTag in InsertUnicodeExtension #46

Closed
Ms2ger opened this issue Jun 4, 2018 · 1 comment
Closed

Unnecessary exception check for IsStructurallyValidLanguageTag in InsertUnicodeExtension #46

Ms2ger opened this issue Jun 4, 2018 · 1 comment

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 4, 2018

  1. Assert: ! IsStructurallyValidLanguageTag(locale) is true.

I don't think there's a need for the !.
@littledan
Copy link
Member

Thanks for this report. You're right, the ! isn't needed. Does anyone want to make a PR to remove it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @littledan