Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshed: name of the "min2" option #23

Closed
sffc opened this issue Oct 8, 2020 · 4 comments
Closed

Bikeshed: name of the "min2" option #23

sffc opened this issue Oct 8, 2020 · 4 comments
Labels
has-consensus Has consensus and ready to implement

Comments

@sffc
Copy link
Collaborator

sffc commented Oct 8, 2020

What should we call the "min2" option for useGrouping? (context: #3)

  1. "min2" (keep it as proposed)
  2. "minimum2" (suggested by @FrankYFTang)
  3. "partial" (suggested by @sffc)
  4. Others?
@sffc sffc added the design Needs design work to make progress label Oct 8, 2020
@FrankYFTang
Copy link
Contributor

FrankYFTang commented Oct 9, 2020

To be clear, I have no opinion about the "name" but rather the "naming convention" of the value of the option. In other part of ECAM402, we use
""best fit" for all Intl objects, (not "best-fit, nor "bestFit" nor "besFit" )
"2-digit" in Intl.DateTimeFormat (not "2Digit", nor "2dig"
"exceptZero" in Intl.NumberFormat (not "except-zero" nor "excZer" )

"min2" , which truncate the first three letter of "minimum" then join with "2" seems yet another new naming convention to me.

"minimum 2" or "minimum two" would be align with "best fit"
"minimum-2" would be align with "2-digit"
"minimum2" or "minimumTwo" would be align with "exceptZero"

but "min2" will be a new kind.

@sffc sffc added discuss Needs discussion to make progress and removed design Needs design work to make progress labels Jan 14, 2021
@sffc
Copy link
Collaborator Author

sffc commented Feb 11, 2021

Or "minimumTwo", most like "exceptZero"?

@sffc
Copy link
Collaborator Author

sffc commented Feb 11, 2021

@justingrant also draws a comparison with h12 and h24. "min2" is similar to those.

@sffc
Copy link
Collaborator Author

sffc commented Feb 11, 2021

2021-02-11: Adopt "min2".

@sffc sffc added has-consensus Has consensus and ready to implement and removed discuss Needs discussion to make progress labels Feb 11, 2021
@sffc sffc closed this as completed in 8d8e9a6 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-consensus Has consensus and ready to implement
Projects
None yet
Development

No branches or pull requests

2 participants