Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should next() include a property with the position? #27

Closed
littledan opened this issue Jun 1, 2018 · 2 comments
Closed

Should next() include a property with the position? #27

littledan opened this issue Jun 1, 2018 · 2 comments

Comments

@littledan
Copy link
Member

The String.prototype.codePoints proposal does. See also tc39/proposal-string-prototype-codepoints#3
@littledan littledan changed the title Should next() return the position? Should next() include a property with the position? Jun 1, 2018
@littledan littledan mentioned this issue Jun 1, 2018
Open
@littledan
Copy link
Member Author

Cc @mathiasbynens

@FrankYFTang
Copy link
Contributor

I think it make sense for

1.5.3.1 %SegmentIteratorPrototype%.next( )

- 13. Return CreateIterResultObject(result, false).
+ 13. Perform ! CreateDataProperty(result, "position", newPosition).
+ 14. Return CreateIterResultObject(result, false).

littledan added a commit that referenced this issue Oct 13, 2018
@littledan
Normative: Include position in segment object
b7f7dbc 
The goal is to allow for easier usability and alignment with the
String.prototype.codePoints proposal.

By @FrankYFTang

Closes #27
@littledan littledan mentioned this issue Oct 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@littledan @FrankYFTang