Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .toArray from this proposal #142

Closed
btoo opened this issue Jul 18, 2021 · 10 comments
Closed

Drop .toArray from this proposal #142

btoo opened this issue Jul 18, 2021 · 10 comments

Comments

@btoo
Copy link
Contributor

btoo commented Jul 18, 2021

.toArray seems needlessly specific since arrays are not the only things that iterators will need to be converted to

It's also redundant because Array.from already exists. Would it not be better to leave it up to each class to implement its own iterator -> class instance constructor (Object.fromEntries, new Set/Set.from, etc.)?

@ljharb
Copy link
Member

ljharb commented Jul 18, 2021

Array.from isn’t chainable, and arrays are, by a large margin, the primary thing iterators are converted into.

@bakkot
Copy link
Collaborator

bakkot commented Jul 18, 2021

See #36 (comment).

@btoo
Copy link
Contributor Author

btoo commented Jul 18, 2021

Array.from isn’t chainable

imo (and it is just an opinion), chainability for non-array-like methods should be de-prioritized while the resolution of the pipeline operator proposal is underway

arrays are, by a large margin, the primary thing iterators are converted into.

See #36 (comment).

i think this offers a great reason not to add a generic .to method, but i would extend this way of thinking to any .to*. if array's are privileged in this context, why can't objects be too? I'm worried this is a slippery slope that results in stuffing too many features into the proposal

@bakkot
Copy link
Collaborator

bakkot commented Jul 18, 2021

if array's are privileged in this context, why can't objects be too?

Because arrays, like iterators and unlike objects, represent a sequence. Arrays are a natural thing to transform iterators into in a way that objects are not.

I'm worried this is a slippery slope

It's exactly one additional, very useful method. The champions have repeatedly refused requests to add other variations. I don't think this slope is very slippery.

@btoo
Copy link
Contributor Author

btoo commented Jul 19, 2021

Because arrays, like iterators and unlike objects, represent a sequence

I think the presupposition that iterators represent a sequence is biased. Yes, they ultimately take form as a sequence, but only because of their lazy nature. It's easily conceivable that developers are using iterators just as collections (orderless)

@ljharb
Copy link
Member

ljharb commented Jul 19, 2021

That doesn’t make any sense to me. A collection doesn’t have an order, iterators do. Certainly iterating an unordered collection requires choosing an order, one that may not matter in that use case, but that doesn’t affect the semantics of iterators - which is, explicitly and unavoidably, an ordered sequence of values.

@btoo
Copy link
Contributor Author

btoo commented Jul 19, 2021

i get that iterators are structured sequentially, but my point is that the intent with which people use them is not necessarily as a sequence

to give an analogous example, arrays are often used to create objects, but they don't have their own .toObject method (that's Object.fromEntries's responsibility) because they are not necessarily intended to be used as enumerated object entries

@btoo btoo closed this as completed Jul 19, 2021
@btoo btoo reopened this Jul 19, 2021
@Nemo64
Copy link

Nemo64 commented Aug 3, 2021

I just want to throw in that there is the pipeline proposal: https://github.com/tc39/proposal-pipeline-operator/wiki
It would allow to do something similar to this.

naturals()
    .filter(n => n > 20)
    .take(20)
    |> Array.from(?)

It looks kind of wrong but it would make it easy to just chain the result in Object.fromEntries Array.from etc.

@btoo
Copy link
Contributor Author

btoo commented Aug 3, 2021

@michaelficarra
Copy link
Member

Arrays are extremely privileged and ubiquitous. For that reason, the toArray helper pays for itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants