This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Array.prototype[@@unscopables] #30

Closed

rkirsling opened this issue Oct 2, 2020 · 0 comments

Member

rkirsling commented Oct 2, 2020

Just so we don't forget: "item" will need to be added to Array.prototype[@@unscopables] before merging to ECMA-262.

The text was updated successfully, but these errors were encountered:

philn pushed a commit to philn/old-webkit that referenced this issue


          [JSC] Add Array#item to @@unscopables

89ba1e5

https://bugs.webkit.org/show_bug.cgi?id=217243

Reviewed by Yusuke Suzuki.

JSTests:

* stress/unscopables.js:
Update test.

Source/JavaScriptCore:

ES2015+ Array methods must be listed in Array.prototype[@@unscopables] per the note here:
https://tc39.es/ecma262/#sec-array.prototype-@@unscopables

The Array#item spec doesn't currently make this explicit, but I created an issue to ensure it isn't overlooked:
tc39/proposal-relative-indexing-method#30

* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):

LayoutTests:

* js/array-unscopables-properties-expected.txt:
* js/script-tests/array-unscopables-properties.js:
Update test.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

syg added a commit that referenced this issue


          Add "at" Array#[@@unscopables] (#30)

07fef45

syg closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.