This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Make new set construction logic internal #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 16, 2019
bakkot
force-pushed
the
internalize-logic
branch
from
46bb70d
to
61b862d
Compare
|
Updated to match #53. |
|
Just gonna rewrite this from scratch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50. Not necessarily proposing that you make this change (though not opposed to it), just wanted it written out.
You can see this rendered here.
The second commit includes the change to
differencediscussed here. In the first commit it does roughly the same thing as currently: i.e., iterate both sets and build up a set which contains things in the first set which are not in the second.(The approach in the first commit corresponds roughly to "take everything in A, and remove from it everything in B", whereas the approach in the second commit corresponds roughly to "take everything in A which is not also in B".)