Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify security story - take 2 (based on PR #378) #380

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Clarify security story - take 2 (based on PR #378) #380

merged 6 commits into from
Jan 27, 2023

Conversation

caridy
Copy link
Collaborator

@caridy caridy commented Nov 16, 2022

Changes:

  • new section about security with all the details
  • explanation based on the taxonomy used for this proposal
  • removed the concept of "trusted" and "untrusted" from the explainer.
  • ShadowRealms -> ShadowRealm

@caridy caridy mentioned this pull request Nov 16, 2022
Closed
mhofman
mhofman approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy suggestions, but the general change looks good!

explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
@caridy @mhofman
Apply suggestions from code review
e14d9f8 
Co-authored-by: Mathieu Hofman <86499+mhofman@users.noreply.github.com>
@caridy caridy requested a review from leobalter January 26, 2023 04:57
@caridy
Copy link
Collaborator Author

caridy commented Jan 26, 2023

@leobalter can you take a look at this, it is pending to be merged.

erights
erights approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
@leobalter
Copy link
Member

LGTM w/ +1 to @erights suggestions.

I just wanna give it another look in the morning time before merging it.

@caridy @erights
Apply suggestions from code review
4c691f8 
Co-authored-by: Mark S. Miller <erights@users.noreply.github.com>
caridy
caridy commented Jan 27, 2023
View reviewed changes
explainer.md Outdated Show resolved Hide resolved
@leobalter leobalter merged commit 5392ab3 into main Jan 27, 2023
@leobalter leobalter deleted the security branch January 27, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofman mhofman mhofman approved these changes

@erights erights erights approved these changes

@leobalter leobalter leobalter approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caridy @leobalter @mhofman @erights @letitz