Normative: Fix off-by-one in BalanceISODate for leap year inputs #1926
Conversation
Instead of setting `testYear` to `year + 1`, and therefore discarding the previous distinction of leap years vs. regular years, just increment it by one. This matches the polyfill's implementation and yields expected results for all inputs. Closes tc39#1923.
Codecov Report
@@ Coverage Diff @@
## main #1926 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 19 19
Lines 10991 10991
Branches 1721 1721
=======================================
Hits 10433 10433
Misses 543 543
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I agree, this is a bug. I will present it in December at TC39.
It seems to be covered by only one test262 test, but there are many more tests in the legacy test suite that cover it, which we will continue to port over, so I'm not worried about test coverage in the long term.
ptomato
added
the
needs plenary input
|
This achieved consensus at the December 2021 TC39 meeting. |
Instead of setting
testYeartoyear + 1, and therefore discarding the previous distinction of leap years vs. regular years, just increment it by one.This matches the polyfill's implementation and yields expected results for all inputs.
Closes #1923.