Editorial: Replace AddDateTime with AddDate #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anba
commented
Jun 5, 2024
|
@anba If you're not in too much of a hurry with this, I'd like to wait until after the TC39 meeting next week when it's clear if there is agreement on removing user-defined calendars. |
|
No, there's no hurry. |
ptomato
requested changes
Jun 28, 2024
Adding a zero-time duration in AddDateTime means that the output date-time record has the same time components as the input date-time record. This allows to directly read the time components from the input date-time record.
Calling AddDateTime with a zero-time duration is equivalent to directly calling AddDate.
|
Rebased to apply on main. |
Implements the editorial improvements from the previous commits, in order to make the reference code follow the spec text more closely.
|
Added a commit to reflect the spec text changes in the polyfill as well, though it has no discernible effect. |
ptomato
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing AddDateTime with AddDate makes it easier (for implementers) to see why it's okay to skip all time duration normalization steps.
e283b59:
9e220c7:
0739c71:
aee3538:
5776d1a: