WIP: Cookbook example showing how to handle icalendar time zones #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Add test data & make sure it works TODO: Comment code better & add page in cookbook
justingrant
approved these changes
Jun 17, 2024
| } | ||
| // this.#impl with a non-IANA time zone uses UTC internally, so we can just | ||
| // calculate the plain date-time in UTC and add the UTC offset. | ||
| return this.#impl.toPlainDateTime().add({ nanoseconds: this.offsetNanoseconds }); |
There was a problem hiding this comment.
Will this break around DST transitions that PDT is unaware of? That may be OK for a cookbook sample, but it may deserve a comment.
There was a problem hiding this comment.
I don't think it'll break. this.#impl.toPlainDateTime() will be unaware of any DST transitions at all, but adding this.offsetNanoseconds will correctly account for DST transitions in the VTIMEZONE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how a ZonedDateTime object with a custom time zone could work, if TimeZone objects are removed. (#2853)
This shows integration with ical.js. It's a ZonedDateTime-wrapper object that internally maintains a real
Temporal.ZonedDateTimeobject, but it takes anICAL.Timezoneinstead of aTemporal.TimeZone. If theICAL.Timezoneobject has the ID of an IANA time zone, we delegate everything to the realTemporal.ZonedDateTimeand use the host's time zone database. If the ID is not an IANA ID, we fall back to theICAL.Timezone'sVTIMEZONEdata.Draft; still needs test data with which to make sure everything works, and a cookbook page.