New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing symbols to strings for Calendar #356
Conversation
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 79.69% 84.01% +4.31%
==========================================
Files 17 17
Lines 3413 3415 +2
Branches 353 384 +31
==========================================
+ Hits 2720 2869 +149
+ Misses 677 517 -160
- Partials 16 29 +13
Continue to review full report at Codecov.
|
docs/calendar-draft.md
Outdated
isoDate: Temporal.Date | ||
) : Temporal.Date; | ||
|
||
/** A string identifier for this calendar */ | ||
[Temporal.Calendar.id] : string; | ||
id] : string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id] : string; | |
id : string; |
altho this should ideally be an accessor on the prototype, rather than an own property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me; up to you whether to change id
to an accessor or not
The |
See #310