Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing symbols to strings for Calendar #356

Merged
merged 2 commits into from Feb 13, 2020
Merged

Changing symbols to strings for Calendar #356

merged 2 commits into from Feb 13, 2020

Conversation

@sffc
Copy link
Collaborator

sffc commented Feb 13, 2020

See #310

@sffc sffc requested review from littledan and ptomato Feb 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #356 into main will increase coverage by 4.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   79.69%   84.01%   +4.31%     
==========================================
  Files          17       17              
  Lines        3413     3415       +2     
  Branches      353      384      +31     
==========================================
+ Hits         2720     2869     +149     
+ Misses        677      517     -160     
- Partials       16       29      +13
Impacted Files Coverage Δ
polyfill/lib/datetime.mjs 81.7% <100%> (+1.76%) ⬆️
polyfill/lib/timezone.mjs 87.2% <100%> (+4.28%) ⬆️
polyfill/lib/time.mjs 74.77% <100%> (+1.71%) ⬆️
polyfill/lib/absolute.mjs 88.38% <100%> (+15.95%) ⬆️
polyfill/lib/date.mjs 72.04% <100%> (+3.53%) ⬆️
polyfill/lib/yearmonth.mjs 77.18% <100%> (+37.84%) ⬆️
polyfill/lib/monthday.mjs 81.2% <100%> (+25.87%) ⬆️
polyfill/lib/ecmascript.mjs 93% <0%> (+0.21%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca126f8...69ce793. Read the comment docs.

isoDate: Temporal.Date
) : Temporal.Date;
/** A string identifier for this calendar */
[Temporal.Calendar.id] : string;
id] : string;

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 13, 2020

Member
Suggested change
id] : string;
id : string;

altho this should ideally be an accessor on the prototype, rather than an own property?

Copy link
Collaborator

ptomato left a comment

👍 from me; up to you whether to change id to an accessor or not

@sffc

This comment has been minimized.

Copy link
Collaborator Author

sffc commented Feb 13, 2020

The id field is super provisional right now, and may be removed once we reach a conclusion on #293.

@sffc sffc merged commit 76f5887 into tc39:main Feb 13, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 79.69%)
Details
codecov/project 84.01% (+4.31%) compared to ca126f8
Details
@sffc sffc deleted the sffc:calendar-update branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.