-
Notifications
You must be signed in to change notification settings - Fork 444
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix DurationFormat default tests (#3640)
1. add the test for "seconds" 2. since the default value for "style" is "long", baseStyle for GetDurationUnitOptions is "long" and therefore the last argument in testOption should be "long" 3. the valid values for "days" does not contains "numeric", and "2-digit". remove them. 4. the valid values for "milliseconds", "microseconds" and "nanoseconds" does not contains "2-digit". remove it. See https://tc39.es/proposal-intl-duration-format/#table-duration-components about the valid value notice the last colum is for "Digital Default" while the baseStyle is "digital" but the set up does not set it that way, the default value for "style" is "long" as in ``` 13. Let style be ? GetOption(options, "style", "string", « "long", "short", "narrow", "digital" », "long"). ``` of https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat * Sync to PR 121 Change default from "long" to "short"
- Loading branch information
1 parent
03cff7f
commit 4569e73
Showing
3 changed files
with
13 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters