Skip to content

Commit

Permalink
Add tests for accessors popping elements
Browse files Browse the repository at this point in the history
  • Loading branch information
mathiasbynens authored and rwaldron committed Jan 27, 2021
1 parent 7733d90 commit 80c18c0
Show file tree
Hide file tree
Showing 2 changed files with 78 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-array.prototype.sort
description: >
Previously implementation-defined aspects of Array.prototype.sort.
info: |
Historically, many aspects of Array.prototype.sort remained
implementation-defined. https://github.com/tc39/ecma262/pull/1585
described some behaviors more precisely, reducing the amount of cases
that result in an implementation-defined sort order.
---*/

const array = [undefined, 'c', /*hole*/, 'b', undefined, /*hole*/, 'a', 'd'];

Object.defineProperty(array, '2', {
get() {
array.pop();
array.pop();
return this.foo;
},
set(v) {
this.foo = v;
}
});

array.sort();

assert.sameValue(array[0], 'b');
assert.sameValue(array[1], 'c');
assert.sameValue(array[3], undefined);
assert.sameValue(array[4], undefined);
assert.sameValue('5' in array, false);
assert.sameValue(array.hasOwnProperty('5'), false);
assert.sameValue(array.length, 6);
assert.sameValue(array.foo, undefined);

assert.sameValue(array[2], undefined);
assert.sameValue(array.length, 4);
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-array.prototype.sort
description: >
Previously implementation-defined aspects of Array.prototype.sort.
info: |
Historically, many aspects of Array.prototype.sort remained
implementation-defined. https://github.com/tc39/ecma262/pull/1585
described some behaviors more precisely, reducing the amount of cases
that result in an implementation-defined sort order.
---*/

const array = [undefined, 'c', /*hole*/, 'b', undefined, /*hole*/, 'a', 'd'];

Object.defineProperty(array, '2', {
get() {
return this.foo;
},
set(v) {
array.pop();
array.pop();
this.foo = v;
}
});

array.sort();

assert.sameValue(array[0], 'a');
assert.sameValue(array[1], 'b');
assert.sameValue(array[2], 'c');
assert.sameValue(array[3], 'd');
assert.sameValue(array[4], undefined);
assert.sameValue(array[5], undefined);
assert.sameValue(array[6], undefined);
assert.sameValue(array.length, 7);
assert.sameValue(array.foo, 'c');

0 comments on commit 80c18c0

Please sign in to comment.