Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for Promise.any proposal #2410

Closed
chicoxyzzy opened this issue Nov 1, 2019 · 8 comments
Closed

Add coverage for Promise.any proposal #2410

chicoxyzzy opened this issue Nov 1, 2019 · 8 comments

Comments

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Nov 1, 2019

This issue is to track the progress of the test262 coverage of the stage 3 Promise.any proposal. https://github.com/tc39/proposal-promise-any. Tests also should cover AggregateError. (covered by #2406)

I'm starting to work on this.

@chicoxyzzy
Copy link
Member Author

cc @mathiasbynens @bakkot

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Nov 1, 2019

Oh, I didn't notice #2406 by @leobalter

@leobalter leobalter changed the title Add coverage for Promise.allSettled proposal Add coverage for Promise.any proposal Nov 1, 2019
@leobalter
Copy link
Member

Hi @chicoxyzzy, how is the progress on the tests for Promise.any? I have time available this week for it if you haven't started yet. Please, let me know!

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Nov 11, 2019

Hi Leo! I have asked you the same question on #tc39 IRC channel couple hours before 😀 I will work on adding Promise.any to JSC soon, so I will need test262 tests. I didn't start yet, so you can take it or leave it to me (I was going to start working on tests tomorrow). Either way works for me 🙂

@leobalter
Copy link
Member

It’s very nice if you wanna write the tests. I’ll focus on other features currently on Stage 3. I’m looking forward to review the tests.

@leobalter
Copy link
Member

Coverage for AggregateError should be done.

@chicoxyzzy
Copy link
Member Author

@leobalter awesome, thank you! I've started to work on Promise.any tests (using #2124 as a reference)

@chicoxyzzy
Copy link
Member Author

#2533 is merged now, so I'll close this issue. Thank you @rwaldron! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants