Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for AggregateError #2406

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Add tests for AggregateError #2406

merged 3 commits into from
Nov 7, 2019

Conversation

leobalter
Copy link
Member

No description provided.

@leobalter leobalter changed the title Add tests for AggregateError [WIP] Add tests for AggregateError Oct 17, 2019
@chicoxyzzy chicoxyzzy mentioned this pull request Nov 1, 2019
Closed
@leobalter leobalter changed the title [WIP] Add tests for AggregateError Add tests for AggregateError Nov 1, 2019
@leobalter
Copy link
Member Author

Coverage for AggregateError#toString is incomplete due to time constraints but I'm leaving this ready to review as I can tackle the remaining parts along a round of feedback or also in another PR.

@leobalter leobalter marked this pull request as ready for review November 1, 2019 21:35
lackeda
lackeda previously approved these changes Nov 2, 2019
View reviewed changes
ljharb
ljharb reviewed Nov 2, 2019
View reviewed changes
test/built-ins/AggregateError/prototype/toString/this-not-object-throws.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/prototype/toString/name.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/prototype/errors/this-is-not-object.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/prototype/errors/return-new-array-from-list.js Show resolved Hide resolved
test/built-ins/AggregateError/prototype/errors/invoked-as-func.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/name.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/message-tostring-abrupt.js Outdated Show resolved Hide resolved
test/built-ins/AggregateError/message-tostring-abrupt-symbol.js Outdated Show resolved Hide resolved
@mathiasbynens mathiasbynens mentioned this pull request Nov 2, 2019
Closed
13 tasks
@leobalter
Copy link
Member Author

@ljharb up for a next round?

@leobalter leobalter merged commit 1bc1935 into tc39:master Nov 7, 2019
@leobalter leobalter deleted the AggregateError branch November 7, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lackeda lackeda lackeda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leobalter @ljharb @lackeda