Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for AggregateError #2406

Merged
merged 3 commits into from Nov 7, 2019

Conversation

@leobalter
Copy link
Member

leobalter commented Oct 17, 2019

No description provided.

@leobalter leobalter changed the title Add tests for AggregateError [WIP] Add tests for AggregateError Oct 17, 2019
@leobalter leobalter force-pushed the leobalter:AggregateError branch from 020a872 to 47a88ff Nov 1, 2019
@leobalter leobalter changed the title [WIP] Add tests for AggregateError Add tests for AggregateError Nov 1, 2019
@leobalter

This comment has been minimized.

Copy link
Member Author

leobalter commented Nov 1, 2019

Coverage for AggregateError#toString is incomplete due to time constraints but I'm leaving this ready to review as I can tackle the remaining parts along a round of feedback or also in another PR.

@leobalter leobalter marked this pull request as ready for review Nov 1, 2019
@mathiasbynens mathiasbynens referenced this pull request Nov 2, 2019
1 of 7 tasks complete
@leobalter

This comment has been minimized.

Copy link
Member Author

leobalter commented Nov 7, 2019

@ljharb up for a next round?

@leobalter leobalter merged commit 1bc1935 into tc39:master Nov 7, 2019
2 of 8 checks passed
2 of 8 checks passed
ci/circleci: ChakraCore: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: JSC: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: SpiderMonkey: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8 --harmony: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: XS: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: Project lint and generation unit tests on Python 3 Your tests passed on CircleCI!
Details
ci/circleci: Project lint, generation tests and build Your tests passed on CircleCI!
Details
@leobalter leobalter deleted the leobalter:AggregateError branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.