built-ins/RegExp/property-escapes/generated need to be updated for Unicode 15.1 #3945
Comments
|
Ref. tc39/ecma262#3073. |
mathiasbynens
added a commit
to mathiasbynens/test262
that referenced
this issue
Apr 15, 2024
ptomato
pushed a commit
to mathiasbynens/test262
that referenced
this issue
Apr 17, 2024
ptomato
pushed a commit
that referenced
this issue
Apr 17, 2024
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this issue
Jun 7, 2024
Summary: Extends RegExp to handle `\p` and `\P` Unicode property escapes, standalone and within character classes, for Unicode mode. The implementation extends the existing idea of tables of codepoint ranges to cover all of the properties explicitly required by ES262. The `genUnicodeTable.py` script was updated to generate code related to the binary and non-binary Unicode properties explicitly mentioned in ES262 ([ref](https://tc39.es/ecma262/multipage/text-processing.html#sec-runtime-semantics-unicodematchproperty-p)); based on the Unicode 15.1.0 data files. Closes #1027 Pull Request resolved: #1295 Test Plan: - Added `regexp_unicode_properties.js` to the Hermes test suite - Binary properties and the General_Category properties - Non-binary properties (Script=Latin, Script_Extensions=Thai) - Inverted character class escapes `\p{…}` and `\P{…}` - All of the above atom escapes in and out of character classes - Exercise the parser for the above forms, and incomplete forms - test262 suite via `hermes/utils/testsuite/run_testsuite.py` - I had to use `--test-skiplist` otherwise around 417 tests (in `test262/test/built-ins/RegExp/property-escapes`) are skipped with the reason "Skipping test with 'const'". This was confusing to me since most of these do pass, but I couldn't find an explainer for this skip. - There are some failures here, at least one of which is caused by [test262 not being updated for Unicode 15.1.0](tc39/test262#3945), which I see as test suite issue rather than an implementation issue. Reviewed By: avp Differential Revision: D56493540 Pulled By: neildhar fbshipit-source-id: 55c86e2d321fc03601b418e0244c099a98759f3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to previous issues like #3663, the files in https://github.com/tc39/test262/tree/main/test/built-ins/RegExp/property-escapes/generated have to be regenerated for Unicode 15.1.
The text was updated successfully, but these errors were encountered: