Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: document setting 'timeout' in tests #55

Closed
smikes opened this issue Jul 24, 2014 · 0 comments · Fixed by #89
Closed

TODO: document setting 'timeout' in tests #55

smikes opened this issue Jul 24, 2014 · 0 comments · Fixed by #89

Comments

@smikes
Copy link
Contributor

smikes commented Jul 24, 2014

When I reviewed the async test code I believe I saw a provision for overriding the default timeout value by setting the timeout attribute on a test -- either via @timeout 100 (old-style) or timeout: 100 (new-style).

Someone (me?) should verify that this exists and document it so that it can be used.

Also, some tests may be designed to time out (e.g., a test of a never-fulfilled promise), so there should be a documented way of writing an async test which is expected to time out.

All of this is necessary because we must avoid the use of setTimeout in Test262 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant