New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.fromEntries: use verifyProperty; add specification details #1677

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@rwaldron
Copy link
Contributor

rwaldron commented Aug 13, 2018

@rwaldron rwaldron requested a review from leobalter Aug 13, 2018


/*---
esid: sec-object.fromentries
description: Closes iterators when toString on a value throws.

This comment has been minimized.

@bakkot

bakkot Aug 13, 2018

Contributor

This test isn't valid; only the keys get toString'd (or, to be precise, toPropertyKey'd). The values are passed through without being touched.

This comment has been minimized.

@rwaldron

rwaldron Aug 13, 2018

Contributor

Whoops, yes, that would make sense. I will drop this.

@bakkot
Copy link
Contributor

bakkot left a comment

Thanks for the followup; sorry for my typos.

@@ -19,7 +36,7 @@ var iterable = {
advanced = true;
return {
done: false,
value: 'null',
value: null,

This comment has been minimized.

@bakkot

bakkot Aug 13, 2018

Contributor

👍

@@ -0,0 +1,64 @@
// Copyright (C) 2018 Kevin Gibbons. All rights reserved.

This comment has been minimized.

@bakkot

bakkot Aug 13, 2018

Contributor

Presumably this (and other new tests) should be (C) someone else?

This comment has been minimized.

@rwaldron

rwaldron Aug 13, 2018

Contributor

Well, I didn't really write a majority of the test, it's your work with only a slight modification

@rwaldron rwaldron force-pushed the ofe-use-verifyproperty branch from 203d874 to ff475fc Aug 13, 2018

@rwaldron

This comment has been minimized.

Copy link
Contributor

rwaldron commented Aug 13, 2018

Thanks for the followup; sorry for my typos.

You're very welcome and don't worry about the typos :)

@leobalter leobalter merged commit ab436c4 into master Aug 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rwaldron rwaldron deleted the ofe-use-verifyproperty branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment