Object.fromEntries: use verifyProperty; add specification details #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Aug 13, 2018
|
|
||
| /*--- | ||
| esid: sec-object.fromentries | ||
| description: Closes iterators when toString on a value throws. |
There was a problem hiding this comment.
This test isn't valid; only the keys get toString'd (or, to be precise, toPropertyKey'd). The values are passed through without being touched.
There was a problem hiding this comment.
Whoops, yes, that would make sense. I will drop this.
bakkot
reviewed
Aug 13, 2018
| @@ -19,7 +36,7 @@ var iterable = { | |||
| advanced = true; | |||
| return { | |||
| done: false, | |||
| value: 'null', | |||
| value: null, | |||
| @@ -0,0 +1,64 @@ | |||
| // Copyright (C) 2018 Kevin Gibbons. All rights reserved. | |||
There was a problem hiding this comment.
Presumably this (and other new tests) should be (C) someone else?
There was a problem hiding this comment.
Well, I didn't really write a majority of the test, it's your work with only a slight modification
rwaldron
force-pushed
the
ofe-use-verifyproperty
branch
from
203d874
to
ff475fc
Compare
You're very welcome and don't worry about the typos :) |
leobalter
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tc39.github.io/proposal-object-from-entries/