-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashbang tests update #2065
Hashbang tests update #2065
Conversation
cc @bmeck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'd still be happier if parseTestRecord.py supported this upstream, so that running the tests in v8 only requires a tiny change to support. |
Yes, I'm yet to look at that part. Thanks for the reminder. |
It wasn't easy to find the bug but I finally figure it out. I'm rewriting this python script to something that reflects better the current reality of Test262 tests but providing the same returns not avoid breaking anything else. I'll let you know when it's ready. |
]) { | ||
assert.throws(SyntaxError, () => ctor('#!\n_',''), `${ctor.name} Call argument`); | ||
assert.throws(SyntaxError, () => ctor('#!\n_'), `${ctor.name} Call body`); | ||
assert.throws(SyntaxError, () => new ctor('#!\n_',''), `${ctor.name} Construct argument`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing space after comma
GeneratorFunction, | ||
AsyncGeneratorFunction, | ||
]) { | ||
assert.throws(SyntaxError, () => ctor('#!\n_',''), `${ctor.name} Call argument`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing space after comma
|
||
assert.sameValue(eval('#!\n'), undefined); | ||
assert.sameValue(eval('#!\n1'), 1) | ||
assert.sameValue(eval('#!2\n'), undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s try both direct and indirect eval
.
re: file names like LGTM % comments |
- indirect eval - files renaming - space after comma
@mathiasbynens I applied the feedback there. Still working on the python script. |
This replaces #1983 with new changes