Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON.stringify stack overflow tests #2517

Merged
merged 3 commits into from Mar 23, 2020
Merged

Add JSON.stringify stack overflow tests #2517

merged 3 commits into from Mar 23, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh commented Mar 4, 2020 •
edited

@shvaikalesh shvaikalesh marked this pull request as ready for review March 23, 2020 17:21
@rwaldron rwaldron merged commit 1eff480 into tc39:master Mar 23, 2020
@devsnek
Copy link
Member

devsnek commented Mar 25, 2020 •
edited

I think these tests be reverted, stack overflows aren't part of the spec and aren't even guaranteed to happen (webkit should feel free to submit these tests to the implementation-contributed directory though)

@shvaikalesh shvaikalesh mentioned this pull request Mar 25, 2020
Merged
@leobalter
Copy link
Member

@devsnek just confirming that #2546 reverts these changes. Thanks for pointing it out. The tests here would be actually non conformant with the infamous Tail Call Optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shvaikalesh @devsnek @leobalter @rwaldron