Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intl[@@toStringTag] coverage #2712

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Add Intl[@@toStringTag] coverage #2712

merged 3 commits into from
Jul 30, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh mentioned this pull request Jul 21, 2020
Merged
@FrankYFTang
Copy link
Contributor

FrankYFTang commented Jul 23, 2020 •
edited
Loading

Please also change https://github.com/tc39/test262/blob/main/test/intl402/Intl/builtin.js

@shvaikalesh shvaikalesh force-pushed the intl402-intl-object-tostringtag branch from 51a2a15 to c46be19 Compare July 23, 2020 07:13
@leobalter leobalter merged commit e0ef80b into tc39:main Jul 30, 2020
pull bot pushed a commit to ashu8912/v8 that referenced this pull request Aug 1, 2020
@FrankYFTang
[Intl] Define @@toStringTag for Intl namespace
439c868 
Implement tc39/ecma402#487
Also improve test/intl/toStringTag.js

see also: tc39/test262#2712

Bug: v8:10744
Change-Id: I678876aa21f169a8dfcec8e3ce974978a8847fe0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315455
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69185}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobalter leobalter leobalter approved these changes

@FrankYFTang FrankYFTang FrankYFTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shvaikalesh @FrankYFTang @leobalter