Fix typos for at/prop-desc tests. #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Nov 19, 2020
https://bugs.webkit.org/show_bug.cgi?id=219124 Reviewed by Yusuke Suzuki. JSTests: * stress/at-method.js: Re-add tests. * test262/config.yaml: Re-enable feature. * test262/expectations.yaml: "at/prop-desc.js" failures are due to a typo; will be fixed in tc39/test262#2908. Source/JavaScriptCore: At this week's TC39 meeting, consensus was achieved on renaming item() *and* keeping it for strings too. Accordingly, this patch reinstates String.prototype.at behind the existing useAtMethod runtime option. * builtins/StringPrototype.js: (at): * runtime/StringPrototype.cpp: (JSC::StringPrototype::finishCreation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@270005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
leobalter
approved these changes
Nov 19, 2020
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=219124 Reviewed by Yusuke Suzuki. JSTests: * stress/at-method.js: Re-add tests. * test262/config.yaml: Re-enable feature. * test262/expectations.yaml: "at/prop-desc.js" failures are due to a typo; will be fixed in tc39/test262#2908. Source/JavaScriptCore: At this week's TC39 meeting, consensus was achieved on renaming item() *and* keeping it for strings too. Accordingly, this patch reinstates String.prototype.at behind the existing useAtMethod runtime option. * builtins/StringPrototype.js: (at): * runtime/StringPrototype.cpp: (JSC::StringPrototype::finishCreation): Canonical link: https://commits.webkit.org/231748@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for copy-paste errors in the verifyProperty change of #2907.
@leobalter @rwaldron