Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Update branch version for ES-META repo #4089

Merged
merged 1 commit into from
May 21, 2024
Merged

chore(ci): Update branch version for ES-META repo #4089

merged 1 commit into from
May 21, 2024

Conversation

Zaid-maker
Copy link
Contributor

@Zaid-maker Zaid-maker commented May 18, 2024 •
edited by Ms2ger

Updates the branch version to clone in CI to v0.4.1.

Changes

@Zaid-maker Zaid-maker requested a review from a team as a code owner May 18, 2024 07:35
@Zaid-maker
Copy link
Contributor Author

Anyone review??

@ljharb
Copy link
Member

ljharb commented May 20, 2024

@jhnaldo, can you confirm?

@jhnaldo
Copy link
Contributor

jhnaldo commented May 20, 2024

@ljharb Yes, I checked that the latest version of ESMeta is compatible with the newest version of Test262. Since the latest version of ESMeta is v0.4.1, I think it is better to update to this version.

I ran all applicable 25,115 Test262 tests and found the following five failed test cases:

  1. language/expressions/assignment/destructuring/keyed-destructuring-property-reference-target-evaluation-order.js
  2. language/expressions/assignment/target-super-computed-reference.js
  3. language/expressions/assignment/destructuring/iterator-destructuring-property-reference-target-evaluation-order.js
  4. language/expressions/member-expression/computed-reference-null-or-undefined.js
  5. language/expressions/assignment/target-member-computed-reference.js

However, all of them are related to tc39/ecma262#3295 and tc39/ecma262#3307. So, updating the version of ESMeta should be fine.

@Zaid-maker, I'm sorry there has been no update on ESMeta, and thanks for your kind suggestion. From now on, I'll update the version of ESMeta for every release, not only in ecma262 but also in test262.

jhnaldo
jhnaldo suggested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I explained in the comment, I suggest to update the version of ESMeta to v0.4.1.

.github/workflows/esmeta-test262.yml Outdated Show resolved Hide resolved
@Zaid-maker
Copy link
Contributor Author

As I explained in the comment, I suggest to update the version of ESMeta to v0.4.1.

Ok

@Zaid-maker Zaid-maker requested a review from jhnaldo May 21, 2024 05:21
jhnaldo
jhnaldo approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jhnaldo jhnaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@Zaid-maker
Copy link
Contributor Author

CI looks happy :)

@ljharb ljharb merged commit ac778ea into tc39:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jhnaldo jhnaldo jhnaldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zaid-maker @ljharb @jhnaldo