Account for the use of ToIndex in Atomic operations #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leobalter
suggested changes
Mar 1, 2017
harness/testAtomics.js
Outdated
| (view) => undefined, // 0 | ||
| (view) => Number.NaN, // 0 | ||
| (view) => 3.5, | ||
| (view) => '3.5', |
There was a problem hiding this comment.
if the length is 3 or more this will fail.
0.5 and '0.5' should avoid this
There was a problem hiding this comment.
Do you mean, if the length is 3 or less this will fail? I'll change this to 0.5 which has the same effect for me, but may still fail if the length is zero. I'll add a comment stipulating the minimum expected length.
harness/testAtomics.js
Outdated
| (view) => Number.NaN, // 0 | ||
| (view) => 3.5, | ||
| (view) => '3.5', | ||
| (view) => ({ password: "qumquat" }), | ||
| (view) => view.length - 1, | ||
| (view) => ({ valueOf: () => 0 }), | ||
| (view) => ({ toString: () => '0', valueOf: false }) // non-callable valueOf triggers invocation of toString |
There was a problem hiding this comment.
you can include false to improve coverage for the ToIndex operation here.
-0.9 should work as a good index as well, weird, but it works.
harness/testAtomics.js
Outdated
| @@ -44,6 +39,11 @@ function testWithAtomicsInBoundsIndices(f) { | |||
| var good_indices = [ | |||
| (view) => 0/-1, // -0 | |||
| (view) => '-0', | |||
| (view) => undefined, // 0 | |||
| (view) => Number.NaN, // 0 | |||
There was a problem hiding this comment.
the regular global NaN should do the trick as well, but it's not necessary to do change this.
leobalter
reviewed
Mar 2, 2017
| @@ -33,16 +33,20 @@ function testWithAtomicsOutOfBoundsIndices(f) { | |||
| * Calls the provided function for each good index that should not throw when | |||
| * passed to an Atomics method on a SAB-backed view. | |||
| * | |||
| * The view must have length greater than zero. | |||
leobalter
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test changes pertain to the spec change in tc39/ecma262#807.