Add tests for Memory persistence method

tcd · Jan 16, 2020 · d3a36fd · d3a36fd
1 parent d6baba3
commit d3a36fd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/lib/eddy/data/persistence/memory.rb b/lib/eddy/data/persistence/memory.rb
@@ -27,18 +27,18 @@ def transaction_set_control_numbers(transaction_set_id)
         end
 
         # @param new_ctrl_num [Integer]
-        # @return [void]
+        # @return [Array<Integer>]
         def add_interchange_control_number(new_ctrl_num)
           self.interchange_control_numbers.append(new_ctrl_num)
-          return nil
+          return self.interchange_control_numbers()
         end
 
         # @param transaction_set_id [String]
         # @param new_ctrl_num [Integer]
-        # @return [void]
+        # @return [Array<Integer>]
         def add_transaction_set_control_number(transaction_set_id, new_ctrl_num)
           self.transaction_set_control_numbers(transaction_set_id).append(new_ctrl_num)
-          return nil
+          return self.transaction_set_control_numbers(transaction_set_id)
         end
 
       end

diff --git a/test/eddy/data/persistence/memory_test.rb b/test/eddy/data/persistence/memory_test.rb
@@ -13,19 +13,23 @@ def teardown
       end
 
       def test_interchange_control_numbers
-        skip()
+        assert_equal([], Eddy.data.interchange_control_numbers())
       end
 
       def test_transaction_set_control_numbers
-        skip()
+        assert_equal([], Eddy.data.transaction_set_control_numbers("850"))
       end
 
       def test_add_interchange_control_number
-        skip()
+        assert_equal([1], Eddy.data.add_interchange_control_number(1))
+        assert_equal([1, 2], Eddy.data.add_interchange_control_number(2))
+        assert_equal([1, 2, 3], Eddy.data.add_interchange_control_number(3))
       end
 
       def test_add_transaction_set_control_number
-        skip()
+        assert_equal([1], Eddy.data.add_transaction_set_control_number("850", 1))
+        assert_equal([1, 2], Eddy.data.add_transaction_set_control_number("850", 2))
+        assert_equal([1, 2, 3], Eddy.data.add_transaction_set_control_number("850", 3))
       end
 
     end