fix issue #1141: immediately report FATAL and PANIC #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors reported at the FATAL or PANIC levels should immediately be reported to Postgres since they ultimately abort the transaction. ERRORs continue to be converted into panics, and everything else is also immediately reported to Postgres but since they only emit messages, there's no change to flow control.
thomcc
approved these changes
May 23, 2023
|
Alrighty, thanks @thomcc. Gonna merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors reported at the FATAL or PANIC levels should immediately be reported to Postgres since they ultimately abort the transaction.
ERRORs continue to be converted into panics, and everything else is also immediately reported to Postgres but since they only emit messages, there's no change to flow control.
As a drive-by, I also added a few functions to the "bad_ideas" example to interactively test this change. It's not really feasible for the test suite to somehow test that a test causes the backend, or the entire cluster, to crash, which is what PANIC and FATAL do.