Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite should clean up after itself #81

Closed
workingjubilee opened this issue Sep 14, 2022 · 0 comments
Closed

Test suite should clean up after itself #81

workingjubilee opened this issue Sep 14, 2022 · 0 comments
Labels
bug Something isn't working test

Comments

@workingjubilee
Copy link
Contributor

Normally, TempDir deletes the directory you made with it when you drop it. This crate uses a Lazy<TempDir> for its tests so that parallel access means the directory is initialized the moment it is needed. However, it is then held in a static TEMP_DIR which means it is simply fixed in memory for the lifetime of the program. This tends to result in the Drop implementation for TempDir not executing properly... accumulating gigabytes of test output shockingly quickly and filling up drives. Either pgx-tests or plrust need to learn how to clean up after themselves.

@workingjubilee workingjubilee added the bug Something isn't working label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Projects
None yet
Development

No branches or pull requests

2 participants