Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lints into their own file #271

Merged
merged 3 commits into from Mar 23, 2023
Merged

Move lints into their own file #271

merged 3 commits into from Mar 23, 2023

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Mar 23, 2023

This changes no logic just where code lives.

workingjubilee
workingjubilee approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't you like having thousands of lines of code in a single file which you have to scroll forever to find any issues in?

@workingjubilee workingjubilee merged commit 8db0a96 into main Mar 23, 2023
8 checks passed
@thomcc thomcc deleted the thomcc/cleanup-plrustc branch March 23, 2023 22:02
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomcc @workingjubilee