Skip to content

Commit

Permalink
scylla-apiclient: drop hk2-locator dependency
Browse files Browse the repository at this point in the history
Drop the dependency of hk2-locator, in order to get rid of javaassist and
other 3rd party dependencies of it.

there are two ways to address this problem:

1. bump up the dependencies which depend on hk2-locator to a version
   which depend on hk2-locator 2.5.0. because hk2-locator 2.5.0 contains a
   change to drop the unnecessary dependencies which made their way into
   the BOM. but they should have not.
2. bump up the dependencies which depend on hk2-locator to a version
   which does not depend on hk2-locator at all.

before this change, per the output of `mvn dependency:tree -Dverbose=true`,
we indirectly depend on hk2-locator 2.4.0.

after this change, hk2-locator dependency is dropped by
bumping up org.glassfish.jersey.core to the oldest stable version which
was released (see https://mvnrepository.com/artifact/org.glassfish.jersey.core/jersey-common/2.27)
after hk2-locator 2.5.0 was released (see
https://mvnrepository.com/artifact/org.glassfish.hk2/hk2-locator/2.5.0-b42),
otherwise we still depend on hk2-locator 2.4.0 indirectly.

verified by running

```shell
mvn dependency:tree -Dverbose=true | grep hk2-locator
```
nothing shows up with this change.

Fixes scylladb#231
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
  • Loading branch information
tchaikov committed Jan 8, 2024
1 parent 80ce599 commit 08b1343
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scylla-apiclient/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<dependency>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-common</artifactId>
<version>2.22.1</version>
<version>2.27</version>
</dependency>
<dependency>
<groupId>javax.ws.rs</groupId>
Expand All @@ -40,7 +40,7 @@
<dependency>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-client</artifactId>
<version>2.22.1</version>
<version>2.27</version>
</dependency>
<dependency>
<groupId>org.glassfish</groupId>
Expand Down

0 comments on commit 08b1343

Please sign in to comment.