Merge pull request vibe-d#2483 from tchaloupka/httpclient_leak

Fix refcounted FD leak in HTTPClient
tchaloupka · Oct 15, 2020 · b5afadb · b5afadb
2 parents a567566 + 61bff81
commit b5afadb
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/http/vibe/http/client.d b/http/vibe/http/client.d
@@ -636,10 +636,8 @@ final class HTTPClient {
 		scope(exit) m_requesting = false;
 
 		if (!m_conn || !m_conn.connected || m_conn.waitForDataEx(0.seconds) == WaitForDataStatus.noMoreData) {
-			if (m_conn) {
-				m_conn.close(); // make sure all resources are freed
-				m_conn = TCPConnection.init;
-			}
+			if (m_conn)
+				disconnect(); // make sure all resources are freed
 
 			if (m_settings.proxyURL.host !is null){