875 generer des liens de partage avec parametre via #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2024 18:21
yostyle
approved these changes
Jun 24, 2024
|
|
||
| NSString *urlPrefix = BuildSettings.clientPermalinkBaseUrl; | ||
| NSString *viaParameters = [NSString stringWithFormat:@"?via=%@", [memberHomeservers.allObjects componentsJoinedByString:@"&via="]]; | ||
| NSString *permalinkToRoom = [NSString stringWithFormat:@"%@/#/room/%@%@", urlPrefix, roomId, viaParameters]; |
There was a problem hiding this comment.
You should update permalinkToRoom in Tools.m from Tchap > Utils and using it. What do you think about that ?
There was a problem hiding this comment.
I thought about it be didn't make it because the modification here, building via parameters does a lot more stuff than permalinkToRoom. It will denaturate permalinkToRoom.
That's why I prefered to define a standalone permalinkToRoomWithoutAliasFromRoomState.
NicolasBuquet
deleted the
875-generer-des-liens-de-partage-avec-parametre-via
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #875
Testé sur :