Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

<code> font does not display numbers #201

Closed
estellecomment opened this issue Feb 28, 2022 · 10 comments · Fixed by #269
Closed

<code> font does not display numbers #201

estellecomment opened this issue Feb 28, 2022 · 10 comments · Fixed by #269
Assignees
Labels
bug Something isn't working v2.4.0 web tchap-web

Comments

@estellecomment
Copy link
Contributor

On OSX, chrome :

<code>0123456789 ABCDE !@#$%^&amp;*()_+{}[]</code>

displays as :

image

This is a problem for displaying device keys in Settings > Security and Privacy. Copy-pasting still works properly though.

@estellecomment estellecomment added bug Something isn't working web tchap-web v2.4.0 labels Feb 28, 2022
@celiacheff
Copy link
Contributor

No problems for me on Manjaro (FF and Chromium). Might be a font bug, can you try with another font maybe ?

@estellecomment
Copy link
Contributor Author

Not present in 2.3.7

@estellecomment
Copy link
Contributor Author

Present in 2.4.0 on OSX on firefox as well

@estellecomment
Copy link
Contributor Author

Present on windows 10 pro, on Chrome, Firefox and Edge

@estellecomment estellecomment self-assigned this Mar 7, 2022
@estellecomment
Copy link
Contributor Author

estellecomment commented Mar 7, 2022

Not present on Ubuntu on Firefox. The font used is Noto.

@celiacheff
Copy link
Contributor

I think the default font was changed in Element, since it had problems, but maybe this one had problems at this point of time

@estellecomment
Copy link
Contributor Author

We have this line in theme-tchap.css (copied from element's theme-light.css and theme-dark.css) :

pre, code {
    font-family: Inconsolata, Twemoji, 'Apple Color Emoji', 'Segoe UI Emoji', 'Noto Color Emoji', Courier, monospace;
    font-size: 100% !important;
}

It looks like inconsolata is not displaying numbers, so Twemoji is displaying them, and Twemoji displays them as squares.
Not clear to me why inconsolata is not displaying the numbers.

@Pascal-aa
Copy link

On the same computer, this bug is :

  • Present on 2.4.0 on Firefox 91.3.0esr (64 bits)
  • Not present on 2.3.7 on Edge 101.0.1210.47 (64 bits)

This bug seems to come with version 2.4.0

@jdauphant
Copy link
Contributor

@jdauphant
Copy link
Contributor

I have made the fix in a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working v2.4.0 web tchap-web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants