This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Monospace Font fixing + Emoji consistency #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature has been tested and can be merged |
celiacheff
approved these changes
Jun 3, 2022
mcalinghee
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font inside code comment are incorrect.
This commit fix the font inconsolata that was loaded in the Tchap Theme. The fix is better for rebase purpose (but we will never rebase this version again ?)
Should also fix emoji on message (use the embedded emoji font instead of the system font)
Linked to https://github.com/tchapgouv/matrix-react-sdk/pull/408
Close #201
Before -> after