feat(role-settings): remove conditional titles for role power level settings #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcWadai
force-pushed
the
1017-roles-power-settings-rename-titles
branch
from
501b6ce
to
4ef6a8e
Compare
MarcWadai
force-pushed
the
1017-roles-power-settings-rename-titles
branch
2 times, most recently
from
82ce3bc
to
3136e9c
Compare
There was a problem hiding this comment.
Es-tu sûr que eventsLevels[M_BEACON_INFO.altName] n'est pas utilisé ailleurs ?
There was a problem hiding this comment.
Dans ce cas oui. J'ai listé la liste des eventTypes et on recoit
- m.beacon_info
- org.matrix.msc3672.beacon_info
Alors que dans le code ce sont bien 2 même valeurs (une stable et l'autre instable)
export const M_BEACON_INFO = new UnstableValue("m.beacon_info", "org.matrix.msc3672.beacon_info")
MarcWadai
force-pushed
the
1017-roles-power-settings-rename-titles
branch
from
3136e9c
to
251cd6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1017