Media and Log functions #135

maximvelichko · 2020-01-02T08:08:35Z

@jessbo's changes to retrieve media files (https://github.com/jessbo/python-amcrest)
Log retrieval functionality

src/amcrest/media.py

coveralls · 2020-01-02T08:10:27Z

Coverage decreased (-0.06%) to 31.678% when pulling ab45ace on maximvelichko:media-log into 3b0457c on tchellomello:master.

src/amcrest/media.py

src/amcrest/log.py

src/amcrest/media.py

maximvelichko · 2020-01-04T17:35:37Z

I believe the code coverage is based on test in tests/test_utils.py
They are for amcrest.utils only, so I see no way to increase the coverage without introducing e.g. mocks for src/amcrest/http.py. (And any added functionality would decrease the coverage).

If I miss something, and there is a way to increase coverage for what I am adding - please let me know, I'd be glad to add it

.travis.yml

src/amcrest/log.py

src/amcrest/media.py

tchellomello

@maximvelichko I've added some comments. Please let me know your thoughts?

@dougsland could we have your sharp eyes on this PR as well?

Thanks guys!

tchellomello

@maximvelichko It looks good!!

@dougsland could you check as well, please?

Thank you!!

examples/get-logs.py

examples/get-files.py

user and others added 2 commits November 25, 2019 09:26

Add "Media" class ; move factory_create() from record.py to media.py

6142afd

Log search functions, http trace requests

9df60a6

houndci-bot reviewed Jan 2, 2020

View reviewed changes

Styling fixes

c7545dc

houndci-bot reviewed Jan 2, 2020

View reviewed changes

Styling fixes - 2

4d4785d

houndci-bot reviewed Jan 2, 2020

View reviewed changes

src/amcrest/media.py Outdated Show resolved Hide resolved

maximvelichko added 3 commits January 2, 2020 09:33

Styling fixes - 3

1071bef

Fix lint issues

0641984

Fix build

38e89f0

houndci-bot reviewed Jan 4, 2020

View reviewed changes

src/amcrest/media.py Show resolved Hide resolved

python 3.4 instead of 3.4.2

a515095

tchellomello requested review from dougsland and tchellomello January 4, 2020 08:49

tchellomello assigned maximvelichko Jan 4, 2020

tchellomello added the enhancement label Jan 4, 2020