Fix error handling for authentication and no longer use session for retries #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 12, 2020
pnbruckner
force-pushed
the
fix-http-command
branch
from
8acefe1
to
9e0c89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_generate_token() only caught CommError's if they happened while trying Basic Authentication. Now it will catch them while trying Digest Authentication.
Clear auth token for any LoginError.
_command() was using a Session() for retry attempts. Don't do this anymore to make it more likely for retry to succeed. Also, for some as of yet unexplained reason using request.get() instead of session.get() seems to prevent intermittent snapshot failures.