Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support amcrest AD110 and other small bugfixes #162

Merged
merged 10 commits into from
Sep 23, 2020

Conversation

blademckain
Copy link
Collaborator

to resolve the requests made here
and to fix other small bugfixes

the main change is in the function

def event_actions(self, eventcodes, retries=None, timeout_cmd=None):

now the tuple never returns
(event name, Start)
but return
(event name, payload)

where payload contains all event information

src/amcrest/record.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 21, 2020

Coverage Status

Coverage decreased (-0.2%) to 31.715% when pulling 8ef01c4 on blademckain:master into 5a9f729 on tchellomello:master.

src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
src/amcrest/event.py Show resolved Hide resolved
src/amcrest/event.py Outdated Show resolved Hide resolved
Copy link
Owner

@tchellomello tchellomello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants