Added OnvifLoginCheck to system #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 13, 2021
src/amcrest/system.py
Outdated
| ret = self.command( | ||
| "configManager.cgi?action=setConfig&UserGlobal.OnvifLoginCheck=false" | ||
| ) | ||
| return ret.content.decode('utf-8') |
src/amcrest/system.py
Outdated
| ) | ||
| else: | ||
| ret = self.command( | ||
| "configManager.cgi?action=setConfig&UserGlobal.OnvifLoginCheck=false" |
There was a problem hiding this comment.
line too long (85 > 79 characters)
src/amcrest/system.py
Outdated
| def onvif_login_check(self, setCheck=False): | ||
| if setCheck == True: | ||
| ret = self.command( | ||
| "configManager.cgi?action=setConfig&UserGlobal.OnvifLoginCheck=true" |
There was a problem hiding this comment.
line too long (84 > 79 characters)
src/amcrest/system.py
Outdated
| @@ -165,3 +165,14 @@ def reboot(self, delay=None): | |||
|
|
|||
| ret = self.command(cmd) | |||
| return ret.content.decode('utf-8') | |||
|
|
|||
| def onvif_login_check(self, setCheck=False): | |||
| if setCheck == True: | |||
There was a problem hiding this comment.
comparison to True should be 'if cond is True:' or 'if cond:'
tchellomello
requested changes
Jul 19, 2021
There was a problem hiding this comment.
@Slyke how about this?
def onvif_login_check(self, setCheck=False):
"""DOC HERE """
cmd = 'configManager.cgi?action=setConfig'
cmd += "&UserGlobal.OnvifLoginCheck={0}".format(str(setCheck))
ret = self.command(cmd)
houndci-bot
reviewed
Jul 24, 2021
| """ | ||
| cmd = 'configManager.cgi?action=setConfig' | ||
| cmd += "&UserGlobal.OnvifLoginCheck={0}".format(str(setCheck)) | ||
| ret = self.command(cmd) |
There was a problem hiding this comment.
local variable 'ret' is assigned to but never used
|
@tchellomello works for me! Updated Note the |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to turn off OnvifLoginCheck. This allows other accounts to use Onvif functionality. currently only the
adminaccount can.Details are in this thread: https://amcrest.com/forum/ip-cameras-f18/ip3m-941b-onvif-and-user-management-t12647-s20.html