Introduces a self._extended_properties cache to the ArloCamera object. #52
Conversation
* This will guarante the data will be cached locally avoid a new query every time
an extended property is requested.
During some tests, the time to load all properties were considerally faster
due to the local cache. If the data demands/requires update, it can be easily
updated by calling the update() method for the ArloCamera object.
This will also contribute to HASS for I/O when reporting the Arlo attributes.
1 similar comment
|
Once if we got this approved, I think we are ready for the next version. |
|
@tchellomello I'm working on some fixes myself. The merge they did earlier today for the dev branch HASS components still throws a lot of errors. I like what you did with the extended properties, but my concern is that it's still making some unnecessary calls to get_camera_properties. A single call gets ALL camera properties, so they should be updated all at once - that's the implementation I'm working on. |
|
@jwillaz Nice!! That is a great idea!! So do you think we can merge this and then you can work on top of this PR to simplify this in a unique call or should we wait for your PR and close this one? I've tested HASS with this implementation and I've seen a huge performance improvement. I'm already excited with a single call then the user's experience will be fantastic! |
|
@tchellomello Yep, go ahead and merge. I'll do a comparison and update accordingly. |
|
@jwillaz awesome So I'll merge and then I'll wait for your PR before publishing the |
|
@tchellomello Allright, we're in business! I just wrapped up the finishing touches and testing. Will submit PR in a few hours. There are definitely changes for the HASS camera and sensor components, so I'll be submitting PRs there as well. |
|
@jwillaz sounds good. As soon as we get you PR for pyarlo merged, we can publish a new version and then you can go ahead and submit the PR's that you have been working on for HASS. Thank you!!! |
Description:
Introduces a self._extended_properties cache to the ArloCamera object.
This will guarantee the data will be cached locally avoid a new query every time
an extended property is requested.
During some tests, the time to load all properties were considerably faster due to the local cache. If the data demands/requires an update, it can be easily updated by calling the update() method for the ArloCamera object.
This will also contribute to HASS for I/O when reporting the Arlo attributes.
Fixes #31