This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
Fix issue where ambient sensor data is never updated #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukiffer
changed the title
lukiffer
changed the title
tchellomello
approved these changes
Jul 2, 2018
|
@lukiffer I'm going to publish the new package tonight. Can you submit a PR to home assistant to bump the pyarlo module too? |
|
@tchellomello I'm wrapping up the unit tests to get home-assistant/core#15074 merged. Should I just bump the package version with that PR or submit a separate one? |
|
@lukiffer you can bump on that PR itself. Give me about 10 minutes and the new package will be published for you. I'll let you know. |
Merged
|
@lukiffer there we go!! https://pypi.org/project/pyarlo/0.1.9/ 0.1.9 is published! Thanks @lukiffer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight on my part originally - the
get_ambient_sensor_data()method was never called when theArloBaseStation.update()method is called.