Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional device kinds for new products #137

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

jsetton
Copy link
Collaborator

@jsetton jsetton commented Oct 17, 2019

Related to #135, I added additional device kinds for new products based on the latest Ring App APK. This also includes adding the new knock detection capability check for the Peephole Cam.

Although, this should covers all the recent Ring product changes. From parsing the APK, it seems that the new Stick Up Cam is using the same device kind cocoa_camera for the battery and wire-in models. At this point, I am not sure how the app is able to differentiate them.

Moreover, there is a device kind called doorbell_scallop which could be the latest generation Doorbell 2 product but it's hard to tell. One thing for sure is that it is a battery operated product. Therefore, I omitted this device kind for the time being.

Finally, the 2nd generation of the Stick Up Cam Elite is identified as stickup_cam_elite_v2 in the app but it is still linked to device kind stickup_cam_elite. So another open question on how it can be differentiated from the previous generation (Elite vs Wired) which I believe doesn't have POE built-in.

@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage decreased (-0.4%) to 63.109% when pulling 8bdc29d on jsetton:device-kinds-upd into 6d2368b on tchellomello:master.

@jsetton
Copy link
Collaborator Author

jsetton commented Oct 17, 2019

@dshokouhi I added additional device kinds to your list.

@tchellomello
Copy link
Owner

@jsetton Thanks for your contribution and I'm sorry for taking too long to approve your PR.

@tchellomello tchellomello merged commit fd0e668 into tchellomello:master Dec 20, 2019
@tchellomello tchellomello mentioned this pull request Dec 20, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants