Add additional device kinds for new products #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #135, I added additional device kinds for new products based on the latest Ring App APK. This also includes adding the new knock detection capability check for the Peephole Cam.
Although, this should covers all the recent Ring product changes. From parsing the APK, it seems that the new Stick Up Cam is using the same device kind
cocoa_camera
for the battery and wire-in models. At this point, I am not sure how the app is able to differentiate them.Moreover, there is a device kind called
doorbell_scallop
which could be the latest generation Doorbell 2 product but it's hard to tell. One thing for sure is that it is a battery operated product. Therefore, I omitted this device kind for the time being.Finally, the 2nd generation of the Stick Up Cam Elite is identified as
stickup_cam_elite_v2
in the app but it is still linked to device kindstickup_cam_elite
. So another open question on how it can be differentiated from the previous generation (Elite vs Wired) which I believe doesn't have POE built-in.