Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return None if no battery installed #185

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

balloob
Copy link
Collaborator

@balloob balloob commented Jan 14, 2020

If a camera has no battery, return None instead of 0 to indicate that there is no battery available.

btw, right now battery_life 1 and 2 are summed if there are 2 battery bays. But shouldn't the result then also be divided by 2? So 2 full batteries is 100, while now it would be 200 ?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 59.275% when pulling 5d497b0 on battery-life-none into b664169 on master.

@tchellomello tchellomello merged commit f71b9bd into master Jan 18, 2021
@tchellomello tchellomello deleted the battery-life-none branch August 7, 2023 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants