[feat] Add support for Light Groups #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the linter failure is broken in |
|
@tchellomello This is ready for your review |
|
Hey @tchellomello -- just wanted to ping to see if you can take a look at this PR and merge if you're alright with it. Let me know if you have any concerns. Thanks! |
|
Thanks again @decompil3d !! You rock! |
|
Awesome! Thanks for merging. Mind publishing a release? I'm planning to make a PR against Home Assistant to apply this new light group support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original goal here was to support the Ring Beams line of products (e.g. lighting transformers), but it seems like their API for that product line is vastly different than the other products, likely because it was from an acquisition. The new API is all web sockets based. And I'm no Python expert, so I'm not able to really dig in to add support for that.
But, it looks like their REST API does provide support for toggling Light Groups. And when you add a new Transformer device to your account, they prompt you to add it into a group. So this is my simpler approach to add support for this product -- just exposing a method to retrieve Light Groups and toggle their light status.
I've confirmed with my own device that this code works as expected. And it is all additive, so it won't cause any API breaks or sudden additional devices for existing consumers of this library.
Like I said, I am definitely not a Python expert. I primarily write JS. So please feel free to tell me where I'm not doing things right or not in the Python way. Happy to adjust as needed.
TODO