This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
Handle the third argument of mb_convert_encoding() being an array #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (0 === strncmp($enc, 'ISO-8859-', 9)) { | ||
| return $enc; | ||
| } | ||
| break; |
There was a problem hiding this comment.
don't need this in the default case
There was a problem hiding this comment.
You mean the break;?
There was a problem hiding this comment.
But what's the purpose of this whole change ?
There was a problem hiding this comment.
array('ASCII', 'ISO-2022-JP', 'UTF-8', 'ISO-8859-1')Without the change, the method would return false for ISO-2022-JP, even though the list contains more, valid charsets. After the change, the unknown charset is ignored, so the list can be run trough until the end and return the correct charset.
|
looks good thanks, I'll merge it today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #51.