This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
CI improvements #68
Closed
CI improvements #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror\\Warning as per change in PHPUnit 6.5.4
|
merged |
|
thank yoy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix the CI errors, however it needs work.
I've renamed
\PHPUnit_Framework_TestCaseto\PHPUnit\Framework\TestCase, as CI is using PHPUnit 5.7.21 and this has been renamed in v5.4.3.Same with
PHPUnit_Framework_Error_Warningas per this commit and this documentation page.I've also removed PHP version which are no longer supported by PHPUnit.
This PR needs probably manual testing and some further work, but most likely I won't be able to continue on this. These are the improvements to tests files which are broken anyway.