Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to GTK 4 and Libadwaita #517

Closed
tchx84 opened this issue Apr 5, 2023 · 0 comments
Closed

Port to GTK 4 and Libadwaita #517

tchx84 opened this issue Apr 5, 2023 · 0 comments

Comments

@tchx84
Copy link
Owner

tchx84 commented Apr 5, 2023

This is just a place holder to trace all the related commits
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Initial port
ae6c437 
Closes tchx84#517

Signed-off-by: Nefo Fortressia <nefothingy@hotmail.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Fix response signal doesn't exist
7fff553 
Closes tchx84#517

Signed-off-by: Nefo Fortressia <nefothingy@hotmail.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Reimplement Find keybinding
bef5eed 
Closes tchx84#517

Signed-off-by: Nefo Fortressia <nefothingy@hotmail.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Run gtk4-builder-tool with the ui files
9a45ecc 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Remove the keybindings
1a17aa1 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Do not destroy rows
5c5af23 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Switch to AdwAboutWindow
978cbdd 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Remove all can-focus properties from builder files
205c810 
This fixes regression issues with focus, as per
tchx84#464 (comment)

Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Fix visibility regression with actionbar
f5e09cc 
Previously, the actionbar will always be visible.
It should have not been that.
Instead, it should only appear when the screen is small.
tchx84#464 (comment)

Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Use navigation-sidebar class in the appslist
e287ce8 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Fix app title size regression
c4af2a1 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@togetherwithasteria @tchx84
gtk4: Port to AdwApplication
0fb77f9 
Closes tchx84#517

Signed-off-by: Fiana Fortressia <fortressnordlys@outlook.com>
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
meson: Require webkitgtk-6.0
e131cb0 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
resetButton: Port to AdwButtonContent
0bd513f 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Port delete-event to close-request vfunc
4061091 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: The backButton should be a regular Button
48c63b5 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
gtk4: Do not set Images as button children
2f091a7 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
detailsButton: Remove can_focus
e5cc53d 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
gtk4: Remove focusable, placeholder, et. al
dffb31f 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Put reset button at the end
bee6a35 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
docsViewer: Port to GTK 4
bf28206 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove requires
878a3aa 
This is a glade only thing.

Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
style: Remove background-color
7db07f1 
Let libadwaita do this.

Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
gtk4: Remove redundant uses of show() & visible
c516076 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
permissionPortalRow: Simplify ui file
07eab7d 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
permissionSwitchRow: Simplify ui file
cdd2795 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
permissionEntryRow: Use flat buttons
f14ac29 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
permissionSwitchRow: Use active instead of state
f4e3c96 
Otherwise active and state do not match causing broken styling.

Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
appInfoViewer: Simplify ui file
b4a64b0 
Closes tchx84#517
tchx84 pushed a commit to A6GibKm/Flatseal that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove placeholders
9fb5237 
Closes tchx84#517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
permissionSwitchRow: Use active instead of state
6cd9405 
Otherwise active and state do not match causing broken styling.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
appInfoViewer: Simplify ui file
3337600 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove placeholders
2527a47 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
pathRow: Remove redundant box
1065591 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
applicationRow: Escape titles
1ed817b 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
style: Restyle permissionEntryRows
d31f6a3 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
style: Use newer css color names
42b07cc 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
pathsViewer: Simplify UI structure
c67440b 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Make menu button accessible and add back F10 accel
9b242e3 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Make separator not navigatable
13df60f 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
main: Set application_name to Flatseal
c51c678 
Note that the name of the app is marked as not translatable, this is in
line with other uses of it.

This will make it so that the default window title is the app name.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
application: Use control instead of primary
0ef1ad0 
This is preferable in GTK 4.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
application: Add accel to close window
ac6453a 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
undoPopup: Use flat class instead of has-frame
8479e03 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove all unneded uses of hexpand
64d00b7 
Its only needed a few times.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove uses of vertical boxes
e55b13a 
This is generally not needed.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Use AdwStatusPage for placeholders
56e6d03 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Port notifications to AdwToast
fbe4311 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
style: Remove unused classes
eb9b3a2 
reset-button was used, but it is wrong.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Add popup-completion=False for EntryCompletions
614ef7b 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
style: Be specific about images with accent color
97abb9f 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Remove applications stack
97b4cd9 
It's actually used but this can be re-implemented
without it.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Simplify app list ui code
d9d4ed1 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Add padding to sidebar
3d27d0d 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
window: Move shutdown to close_request
9dc16e3 
The 'destroy' signal is not being emitted.

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
application: Use GtkUriLauncher for uris
9a0e8d9 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
settings: Port saveWindowState to gtk4
9ae6c51 
Prefer to use default size and the actual property "maximized".

Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
tests: Update to gtk4
5264747 
Closes #517
tchx84 pushed a commit that referenced this issue Apr 5, 2023
@A6GibKm @tchx84
ui: Remove receives-default
36af875 
Closes #517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tchx84