Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions approval #4

Closed
thejerome opened this issue Aug 21, 2018 · 4 comments
Closed

Solutions approval #4

thejerome opened this issue Aug 21, 2018 · 4 comments
Labels
kind/enhancement Proposal for an improvement.

Comments

@thejerome
Copy link

It would be good to add a column for a manual check.
Meaning - tutor can review pull request and consider it good, so he can just can hit a checkbox or choose an option something like that just to remember that check was done and its result is good or not.
Or at least it can be a short comment column.

@thejerome
Copy link
Author

One more option is to have an ability to commit the result for particular pair of task and student - just having a button to say "It is cheked, result is set" that will make the line readonly and will change it style so it can be distinguished from lines that are still open for modification. Of course such closing should be revertable.

@tcibinan
Copy link
Owner

tcibinan commented Sep 2, 2018

GitHub has its own mechanism of manual checking - pull requests reviews. I suppose the most natural way for Flaxo is to synchronize its checks with GitHub ones.

@tcibinan tcibinan changed the title Manual check column Solutions approval Sep 2, 2018
@tcibinan tcibinan added the kind/enhancement Proposal for an improvement. label Sep 2, 2018
@tcibinan
Copy link
Owner

tcibinan commented Oct 9, 2018

The current solution looks like the following.

The task statistics table should be expanded with an additional approved column which basically is a set of checkboxes. If checkbox is checked then it means that a solution is approved. If it is not then solution is not approved or requires changes.

updated task statistics table

If user toggles checkbox to an active state then flaxo will create an approval review on the pull request.
If user toggles checkbox to an inactive state then after user enters small review message flaxo will create a changes required review on the pull request.

@tcibinan tcibinan closed this as completed Oct 9, 2018
@tcibinan tcibinan reopened this Oct 9, 2018
@tcibinan
Copy link
Owner

Done in 6365ef1 ... d70fb35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Proposal for an improvement.
Projects
None yet
Development

No branches or pull requests

2 participants