Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign solution approval mechanism #26

Open
tcibinan opened this issue Apr 7, 2019 · 0 comments
Open

Redesign solution approval mechanism #26

tcibinan opened this issue Apr 7, 2019 · 0 comments
Labels
area/client Issue related to web client. area/server Issue related to server. kind/enhancement Proposal for an improvement.

Comments

@tcibinan
Copy link
Owner

tcibinan commented Apr 7, 2019

Summary

Solution approvals was introduced in #4.

It turned out that the original implementation does not suit tutor needs very well.

First of all, a solution can only be in one of two states: approved or disapproved. Therefore, as long as solution has been created it instantly becomes disapproved. It may be confusing and even adverse. F.e. if tutor wants to request changes on a reviewed newest solution he has to mark a solution as approved to be able to mark it as disapproved after.

Moreover, it brings some inconsistency with pull request reviews. Once created a solution has a disapproved status in flaxo but does not have any backing pull request review after it.

The last problem lies in solutions approval UI representation. Only checkboxes are displayed bringing no addition information about the message or the review creation date.

Capture

Proposal

Solution approval should have three possible state: none, dissaproved and approved. The last two states can have an associated message and it should be visible for a tutor as well as editable while approval creation.

The idea is to replace a single instanced solution approval with a series of approvals. Each one of the approvals should have a backing pull request review. The series can be shown in the task solutions table after a clicking on a specific solution row. An approval creation button should be right at the end of the approval series.

@tcibinan tcibinan added area/client Issue related to web client. area/server Issue related to server. kind/enhancement Proposal for an improvement. and removed enhancement labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client Issue related to web client. area/server Issue related to server. kind/enhancement Proposal for an improvement.
Projects
None yet
Development

No branches or pull requests

1 participant