New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVO UIScrollView contentOffset #41
Conversation
The noticeView scroll with the scrollView.
- merged #30 from master - now WBNoticeView automatically add itself has observer for "contentOffset" when view is an UIScrollView
Mmm now there are duplicate commits, it's a problem? (I need to learn how to use git correctly) |
I'm currently struggling with the same wish: Make the WBSuccessNoticeView *notice;
notice = [WBSuccessNoticeView successNoticeInView:self.view.superview
title:@"You're offline, will submit later."];
[NSOperationQueue addNoticeView:notice filterDuplicates:YES]; |
@plu Your solution works (only) if the scrollview and its superview have the same frame. |
@Frugghi you're right, my solution isn't flawless and it only works if the frame is the same. I could not test your fork though, it does not apply cleanly upon the current master anymore. |
@Frugghi Sorry, but I cannot merge the fix automatically:
Could you please revise the change and try once more? Many thanks! |
I merged your master and made the changes again, now automatically merge should work.